[Bug 1934194] Review Request: python-libcst - A concrete syntax tree with AST-like properties for Python 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1934194



--- Comment #7 from code@xxxxxxxxxxxxxxxxxx ---
> Note that even with the intersphinx fix you suggested I still get: …

Hmm, you’re right. It looks like intersphinx does not like file:// URIs, but it
does accept plain old paths
(https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping).
That should have been:

  # Use local intersphinx inventory
  sed -r -i 's|https://docs.python.org/3|file:/%{_docdir}/python3-docs/html|' \
      docs/source/conf.py

I had to fix this on my own package too:
https://bugzilla.redhat.com/show_bug.cgi?id=1934257

----

  %if 0%{?fedora} < 33 || 0%{?rhel} < 9

is not correct; either %fedora or %rhel is undefined, so either 0%{?fedora} is
0, which is less than 33, or 0%{?rhel} is 0, which is less than 9. So it always
evaluates true.

If this came from pyp2rpm, then it is a bug in pyp2rpm.

If you are not building for EPEL, you can just check if 0%{?fedora} == 32.

----

I’m getting

- Packages MUST NOT have dependencies (either build-time or runtime) on
  packages named with the unversioned python- prefix unless no properly
  versioned package exists. Dependencies on Python packages instead MUST
  use names beginning with python2- or python3- as appropriate.
  Note: Unversionned Python dependency found.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Python/#_dependencies

which I though was a false positive, triggered by the documentation package

    %package -n     python-%{pypi_name}-doc

It would be much more conventional to write that as

    %package        doc

which, with python-%{pypi_name} as the base name, would still give you the same
subpackage name.

I tested it with that change and still had the complaint, though.

I’m getting

Requires
--------
python3-libcst (rpmlib, GLIBC filtered):
    python(abi)
    python3.9dist(pyyaml)
    python3.9dist(typing-extensions)
    python3.9dist(typing-inspect)

Provides
--------
python3-libcst:
    python-libcst
    python3-libcst
    python3.9-libcst
    python3.9dist(libcst)
    python3dist(libcst)

so something is going on that has nothing to do with the documentation.

I’ll post a full review after I figure out what the problem is.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux