https://bugzilla.redhat.com/show_bug.cgi?id=1913737 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |projects.rg@xxxxxxxx --- Comment #9 from Raphael Groner <projects.rg@xxxxxxxx> --- Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=63021594 GPL (v2 or later) ----------------- POL-POM-4-4.4/python/configurewindow/ConfigureWindow.py POL-POM-4-4.4/python/debug.py POL-POM-4-4.4/python/install/InstallWindow.py POL-POM-4-4.4/python/mainwindow.py POL-POM-4-4.4/python/options.py POL-POM-4-4.4/python/setupwindow/POL_SetupFrame.py POL-POM-4-4.4/python/setupwindow/gui_server.py POL-POM-4-4.4/python/wine_versions/WineVersionsWindow.py POL-POM-4-4.4/python/wrapper.py MIT/X11 (BSD like) ------------------ POL-POM-4-4.4/src/check_direct_rendering.c Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. => Licenses GPLv2 and MIT/X11 (latter one file only) [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1913737-playonlinux/playonlinux/licensecheck.txt => Add MIT for special file listed above or explain exception. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/appdata [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. => Verified by succesful scratch build in rawhide. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [-]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines => License fix needed. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 2.9 starting (python version = 3.6.8, NVR = mock-2.9-1.el7)... Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.9 INFO: Mock Version: 2.9 Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.9 INFO: Mock Version: 2.9 Finish: chroot init INFO: installing package(s): /builddir/playonlinux-4.4-1.fc35.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M f206b85a84fe47f6afef95951e832e06 -D /var/lib/mock/epel-7-x86_64-bootstrap/root --capability=cap_ipc_lock --bind=/tmp/mock-resolv.jqzsy6yk:/etc/resolv.conf --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/epel-7-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 /usr/bin/yum --installroot /var/lib/mock/epel-7-x86_64/root/ --releasever 7 install /builddir/playonlinux-4.4-1.fc35.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: playonlinux-4.4-1.fc35.x86_64.rpm playonlinux-4.4-1.src.rpm playonlinux.x86_64: W: binaryinfo-readelf-failed /usr/libexec/playonlinux-check_dd readelf: /tmp/rpmlint.playonlinux-4.4-1.fc35.x86_64.rpm.rZ3H6M/usr/libexec/playonlinux-check_dd: Error: No such file playonlinux.x86_64: W: binaryinfo-tail-failed /usr/libexec/playonlinux-check_dd: [Errno 2] No such file or directory: '/tmp/rpmlint.playonlinux-4.4-1.fc35.x86_64.rpm.rZ3H6M/usr/libexec/playonlinux-check_dd' playonlinux.x86_64: W: only-non-binary-in-usr-lib playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/setupwindow/__pycache__/__init__.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/wine_versions/__pycache__/WineVersionsTools.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/configurewindow/__pycache__/PackageList.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/wine_versions/__pycache__/WineVersionsNotebook.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/ui/__pycache__/PlayOnLinuxWindow.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/__pycache__/debug.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/setupwindow/__pycache__/gui_server.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/setupwindow/__pycache__/POL_SetupFrame.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/configurewindow/__pycache__/ConfigureWindow.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/lib/__pycache__/playonlinux.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/install/__pycache__/InstallWindow.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/install/__pycache__/DescriptionFetcher.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/configurewindow/__pycache__/__init__.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/install/__pycache__/MiniatureWindow.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/__pycache__/options.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/configurewindow/__pycache__/ConfigureWindowNotebook.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/wine_versions/__pycache__/__init__.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/install/__pycache__/__init__.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/__pycache__/mainwindow.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/__pycache__/wrapper.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/__pycache__/check_python.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/lib/__pycache__/Variables.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/lib/__pycache__/wine.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/lib/__pycache__/__init__.cpython-39.opt-1.pyc playonlinux.x86_64: W: hidden-file-or-dir /usr/lib/.build-id playonlinux.x86_64: W: hidden-file-or-dir /usr/lib/.build-id playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/wine_versions/__pycache__/WineVersionsFetcher.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/lib/__pycache__/dpiFetcher.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/wine_versions/__pycache__/WineVersionsWindow.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/setupwindow/__pycache__/Downloader.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/ui/__pycache__/__init__.cpython-39.opt-1.pyc playonlinux.x86_64: W: python-bytecode-without-source /usr/share/playonlinux/python/lib/__pycache__/lng.cpython-39.opt-1.pyc playonlinux.x86_64: E: invalid-desktopfile /usr/share/applications/PlayOnLinux.desktop playonlinux.x86_64: E: non-utf8-desktopfile /usr/share/applications/PlayOnLinux.desktop 0 packages and 0 specfiles checked; 2 errors, 35 warnings. Requires -------- playonlinux (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 ImageMagick cabextract curl gettext gnupg2 icoutils jq libGL.so.1()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) nc p7zip-plugins python3 python3-natsort python3-wxpython4 rtld(GNU_HASH) tar unzip wget wine xterm Provides -------- playonlinux: application() application(PlayOnLinux.desktop) metainfo() metainfo(PlayOnLinux.appdata.xml) playonlinux playonlinux(x86-64) Source checksums ---------------- https://github.com/PlayOnLinux/POL-POM-4/archive/4.4/POL-POM-4-4.4.tar.gz : CHECKSUM(SHA256) this package : a3536243772002d17b9c5fcfd616844134bcfe126ce7b7b24eb971ba1f63365d CHECKSUM(SHA256) upstream package : a3536243772002d17b9c5fcfd616844134bcfe126ce7b7b24eb971ba1f63365d Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review --prebuilt --rpm-spec -n playonlinux-4.4-1 Buildroot used: epel-7-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
