https://bugzilla.redhat.com/show_bug.cgi?id=1934402 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- It would be great if you added a comment above the chmod line (why is this necessary? those files should not have the executable bit set, and it breaks things). Upstream project seems to be dead, so I'm not sure if it's going to help if you open a pull request there to fix the permissions in the git repository. Other than that: Package generated with rust2rpm, simplifying the review. - package conforms to Rust Packaging Guidelines - package builds and installs successfully on rawhide - latest version is packaged - license matches upstream and license file is installed with %license - tests are run (but there are no tests in the project :sad-face:) Package APPROVED. Please add the comment about why the "chmod -x" step is necessary to the .spec file before committing it into dist-git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
