Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility https://bugzilla.redhat.com/show_bug.cgi?id=222338 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora akahl@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akahl@xxxxxxxxxxxxxx ------- Additional Comments From akahl@xxxxxxxxxxxxxx 2007-11-13 21:39 EST ------- This is not a formal review as I am not a sponsor: * rpmlint: - W: invalid-license GPL GPL is not a valid license, please use GPLv2[+] or GPLv3[+] instead. According to the COPYING file and the source file's headers, the license is GPLv2+. - W: non-conffile-in-etc /etc/gconf/schemas/initng-conf-gtk.schemas This can be ignored as gconf schema files always have to be overwritten on package updates. * The package is named according to the Package Naming Guidelines * The spec file name matches the base package * Fedora approved license (GPLv2+) E License field in the package spec file DOES NOT match the actual license * Latest version is being packaged * Dist tag is present * Build root is correct * The sources used to build the package matches the upstream source 0dba2797764b33e1f58931a4ed11d465adc4d2ce initng-conf-gtk-0.5.tar.gz * The spec file is written in American English * The spec file is legible * Builds in mock (dist-f8) http://koji.fedoraproject.org/koji/taskinfo?taskID=240809 * All build dependencies are listed in BuildRequires * %install starts with build root clean * %clean starts with build root clean * Package own all directories that it creates E Package owns files or directories already owned by other packages /usr/share/icons/hicolor/16x16 /usr/share/icons/hicolor/16x16/apps /usr/share/icons/hicolor/22x22 /usr/share/icons/hicolor/22x22/apps /usr/share/icons/hicolor/24x24 /usr/share/icons/hicolor/24x24/apps /usr/share/icons/hicolor/32x32 /usr/share/icons/hicolor/32x32/apps /usr/share/icons/hicolor/36x36 /usr/share/icons/hicolor/36x36/apps /usr/share/icons/hicolor/48x48 /usr/share/icons/hicolor/48x48/apps I suggest replacing line 92 with %{_datadir}/icons/hicolor/*/apps/initng.png to solve this. * GConf part looks OK E Scriptlets are NOT sane: - desktop-database part is not OK Please update the affected parts according to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets The desktop file is installed properly. - Scrollkeeper part is not OK Update according to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets as above * No library * Locale part handled properly * Consolehelper part looks OK * debuginfo package looks complete * No duplicates in %files * File permissions are appropriate * The package contains code * All filenames are valid UTF-8 * No pkgconfig files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review