https://bugzilla.redhat.com/show_bug.cgi?id=1933988 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #3 from code@xxxxxxxxxxxxxxxxxx --- It seems like upstream hasn’t really had either commits nor bug reports since late 2018, so I could understand the potential need for a “maintained fork.” Is that what’s happening here? It seems reasonable as long as you plan to continue maintaining it and as long as you do not diverge from the original upstream in ways that would make the fork unsuitable for dependent packages other than COPASI. I think a comment in the spec file describing these plans would be very helpful. The package fails to build in mock for me: + /usr/bin/cmake -S . -B x86_64-redhat-linux-gnu -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_BUILD_TYPE:STRING=Release '-DCMAKE_CXX_FLAGS_RELEASE:STRING=-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG' '-DCMAKE_C_FLAGS_RELEASE:STRING=-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG' -DCMAKE_VERBOSE_MAKEFILE:BOOL=TRUE -DCMAKE_SKIP_INSTALL_RPATH:BOOL=YES -DNATIVEJIT_VERSION_MAJOR=0 -DNATIVEJIT_VERSION=0 CMake Error at CMakeLists.txt:3 (cmake_minimum_required): cmake_minimum_required called with unknown argument "[FATAL_ERROR]". -- The CXX compiler identification is GNU 11.0.0 -- The C compiler identification is GNU 11.0.0 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/g++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/gcc - skipped -- Detecting C compile features -- Detecting C compile features - done -- ######################################## NativeJIT is root -- Found GTest: /usr/lib64/libgtest.so -- Configuring incomplete, errors occurred! See also "/builddir/build/BUILD/nativejit-v0.0/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log". See also "/builddir/build/BUILD/nativejit-v0.0/x86_64-redhat-linux-gnu/CMakeFiles/CMakeError.log". I am attaching CMakeOutput.log and CMakeError.log. In addition to the problem with cmake_minimum_required, it looks like there are problems with using C++ flags on a C source, which are being treated as errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
