https://bugzilla.redhat.com/show_bug.cgi?id=1933412 --- Comment #3 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Some more nitpicking: I prefer to list BuildRequires one per line and sorted alphabetically. That makes them more readable and makes the future diffs smaller in case you need to change them. You should use BuildRequires: cmake instead of cmake3 if you're not planning an EPEL7 package, especially since you're not using %cmake3_* macros, only %cmake_*. Either way, please be consistent here. Is there a particular reason not to name this simply "cpu_features" without the google- prefix? Also, please add an empty line before %description devel. Regarding %build section, -DBUILD_SHARED_LIBS:BOOL=ON and -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON are already supplied by %cmake macro, no need to duplicate. CMakeLists.txt has this: if(BUILD_SHARED_LIBS AND UNIX) set(BUILD_PIC ON) endif() so it looks like -DBUILD_PIC:BOOL=ON is redundant as well. Similar to BuildRequires, it's better to put each argument to %cmake on a separate line, like this: %cmake \ -DBUILD_TESTING:BOOL=ON \ -DCMAKE_BUILD_TYPE:STRING=Release \ -DCMAKE_SKIP_INSTALL_RPATH:BOOL=YES \ -DCPUFEATURES_VERSION_MAJOR:STRING=0 \ -DCPUFEATURES_VERSION:STRING=0.6 \ %cmake_build I'd also add CONTRIBUTING.md as %doc to -devel package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
