https://bugzilla.redhat.com/show_bug.cgi?id=1926697 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(decathorpe@gmail. | |com) | --- Comment #30 from Fabio Valentini <decathorpe@xxxxxxxxx> --- %global major 7.0 %global minor b10 Name: openjdk-asmtools Version: %{major}.%{minor} Release: pre.0.1%{?dist} - "pre" does not belong anywhere - which upstream commit is used? it is not defined Something like this should be used if you want to use "pre-release" snapshot versioning: %global major 7.0 %global minor b10 %global commit 40-CHARACTER-HASH-VALUE %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate YYYYMMDD Name: openjdk-asmtools Version: %{major}.%{minor} Release: 0.1.%{commitdate}.git%{shortcommit}%{?dist} [...] Source0: https://github.com/openjdk/asmtools/archive/%{commit}/%{name}-%{shortcommit}.tar.gz [...] %autosetup -n asmtools-%{commit} Or, if you want to use "post-snapshot" versioning instead, it should be: %global major 7.0 %global minor b09 %global commit 40-CHARACTER-HASH-VALUE %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global commitdate YYYYMMDD Name: openjdk-asmtools Version: %{major}.%{minor} Release: 1.%{commitdate}.git%{shortcommit}%{?dist} [...] Source0: https://github.com/openjdk/asmtools/archive/%{commit}/%{name}-%{shortcommit}.tar.gz [...] %autosetup -n asmtools-%{commit} The only differences are: - leading "0." in Release for pre-release snapshot, such that proper version sorts higher - no leading "0." for post-release snapshot, such that it will sort higher than last proper version But specifying the commit and date is mandatory in either case. (I agree, the <snapinfo> stuff from the Guidelines is very hard to understand.) And do not download sources manually. If necessary, use "spectool -g", it will evaluate macros from the spec use the correct output name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
