[Bug 1931477] Review Request: python-openant - A python library to communicate with ANT-FS compliant devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1931477



--- Comment #3 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
hey!

Everything seems fine now. Please regenerate the SRPM from the spec file.

```
Diff spec file in url and in SRPM
---------------------------------
--- /home/major/Documents/NeuroFedora/review/python-openant.spec       
2021-03-02 12:49:03.800246208 +0530
+++
/home/major/Documents/NeuroFedora/review/review-python-openant/srpm-unpacked/python-openant.spec
   2021-02-26 19:15:38.000000000 +0530
@@ -65,6 +65,6 @@
 %changelog
 * Fri Feb 26 2021 Iztok Fister Jr. <iztokf AT fedoraproject DOT org> - 0.4-1
-- Added comment for patch
-- Fixed Unowned Directories
+- Patch documentation
+- Directories change
```

Also, please consider these rpmlint warnings:

```
Rpmlint
-------
Checking: python3-openant-0.4-1.fc35.noarch.rpm
          python-openant-0.4-1.fc35.src.rpm
python3-openant.noarch: W: non-etc-or-var-file-marked-as-conffile
/usr/lib/udev/rules.d/ant-usb-sticks.rules
python-openant.src:28: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab:
line 28)
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

```

Approving the review since these are minor changes.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux