https://bugzilla.redhat.com/show_bug.cgi?id=1926697 --- Comment #26 from Jaya <jhuttana@xxxxxxxxxx> --- I have addressed the latest review comments and uploaded the files Spec file URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.spec SRPM URL: https://jhuttana.fedorapeople.org/openjdk-asmtools-7.0.b10.pre.0.1-0.1.20210122.7eadbf.fc35.src.rpm Man Page URL: https://jhuttana.fedorapeople.org/openjdk-asmtools.1 Launcher URL: https://jhuttana.fedorapeople.org/openjdk-asmtools (In reply to Fabio Valentini from comment #23) > I wonder where the .pre.0.1 part of the Version comes from? > It does not exist in the upstream project. > > If you want to denote that it's a pre-release snapshot, then you're doing it > wrong, since your string sorts higher than the eventual Release string. > Instead, you should use: > Release: 0.1.{snapshot info}%{?dist} > > See: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_snapshots I tried to understand <snapinfo> and modified the 'Release' tag. Could you please take a look? (In reply to jiri vanek from comment #21) > [!] Fabio is right in c#15 - please instead of wget -O > asmtools-7.0.b10.pre.0.1.tar.gz > https://github.com/openjdk/asmtools/archive/master.zip use snapshot of > current latest commit in master. Issue is, that if one would attmept to > regenerate the sources, from yor link they wouldbe different. From exact > commit, they will be same. > Yes. I am not getting how to do that !! I will try to find out. And also, for the rpmlint warning: > openjdk-asmtools.noarch: W: incoherent-version-in-changelog 0.1-1 ['7.0.b10.pre.0.1-1.fc34', '7.0.b10.pre.0.1-1'] , I have made the change in the changelog entry looking at the srpm generated : openjdk-asmtools-7.0.b10.pre.0.1-0.1.20210122.7eadbf.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
