https://bugzilla.redhat.com/show_bug.cgi?id=1933464 --- Comment #4 from Davide Cavalca <dcavalca@xxxxxx> --- I'll do a formal review once the dependencies are in, as this cannot be installed as-is. Some notes: - use %license instead of %doc for the license - use %global instead of %define for the constants - spec/commands_spec.rb seems to be tripping up licensecheck - the test suite is mandatory for ruby packages per policy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
