https://bugzilla.redhat.com/show_bug.cgi?id=1926697 --- Comment #19 from jiri vanek <jvanek@xxxxxxxxxx> --- %global major 7.0 %global minor b09 Name: openjdk-asmtools Version: 7.0.b10.pre.0.1 I think it should be %global major 7.0 %global minor b10 Name: openjdk-asmtools Version: %{major}.%{minor}.pre.0.1 or not? #%setup -q -n asmtools-%{version} should be #%%setup -q -n asmtools-%%{version} Setup is multiline macro. Ohterwise it looks really good. I have one more "strange" request. which you mal revoke, but woudl be nice to have. Can you please change https://jhuttana.fedorapeople.org/openjdk-asmtools to openjdk-asmtools.in and generate from it openjdk-asmtools, openjdk-asmtools-jasm, openjdk-asmtools-jdis, openjdk-asmtools-jcoder, openjdk-asmtools-jdec and openjdk-asmtools-jcdec ? the onl diffeerence will be in main method an name... A bit of absh exercise :) Manual testing is now pass from me. Will push the review again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
