https://bugzilla.redhat.com/show_bug.cgi?id=1928694 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from code@xxxxxxxxxxxxxxxxxx --- Not a full review, but some comments at first glance: ----- You should attempt to unbundle afdko, which is already in Fedora as adobe-afdko. Otherwise, you must handle it as specified in https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. I think you can do this by patching out the “tx = Executable(…)” section in setup.py, and just symlinking /usr/bin/tx in the right place. At this point the package could even become noarch, as the bundled executable is the only compiled code. ----- You should not be adding %global debug_package %{nil} without a good reason. It should be possible to build this with proper debuginfo. ----- The package fails to build in mock because it is looking for setuptools-git-ls-files. I have submitted this for review, and you could review it to get it quickly added to Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1909400), but there may be further patching and workarounds required. After all, the purpose is to use git metadata, which is not in the release tarball, so having the dependency packaged might not help at all. ----- The %python_provide macro is obsolete and should not be used in Fedora. If you are targeting Fedora 32, you can use %py_provides, otherwise nothing is needed. (I like to wrap %py_provides in %if 0%{?fedora} == 32 / %endif as a reminder it should be removed after Fedora 32 EOL.) See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro. ----- %{python3_sitearch}/%{srcname}-*.egg-info %{python3_sitearch}/%{srcname}/*.py %{python3_sitearch}/%{srcname}/__pycache__ %{python3_sitearch}/%{srcname}/tx would be more conventionally and, I think, better written as %{python3_sitearch}/%{srcname} %{python3_sitearch}/%{srcname}-%{version}-py%{python3_version}.egg-info ----- It is helpful to run the fedora-review tool on your own RPM to flush out any problems. ----- I have my own reasons for wanting this in Fedora, so I’m willing to help out quite a bit getting the spec file improved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
