https://bugzilla.redhat.com/show_bug.cgi?id=1926697 --- Comment #15 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Yes, this is like the recommended approach for packaging maven projects: https://fedora-java.github.io/howto/latest/#maven However, I see one big issue: do **never** reference an upstream *branch*, only *commits* or *tags*. Branches are moving targets, so it is unclear which state of the repository you are referencing. Please refer to https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services for the latest Guidelines on how to handle git snapshots (there's even ready-for-use snippets for GitHub). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure