[Bug 1926697] Review Request: openjdk-asmtools - An OpenSource project to develop tools for the production of proper and improper Java '.class' files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1926697



--- Comment #11 from Jaya <jhuttana@xxxxxxxxxx> ---
%files
%license LICENSE
%doc README.md
/usr/share/java/openjdk-asmtools/*
/usr/share/javadoc/openjdk-asmtools/*
/usr/share/maven-metadata/*
/usr/share/maven-poms/openjdk-asmtools/*
%attr(755, root, -) %{_bindir}/openjdk-asmtools

-> I really od not like aserixes here. Please enumerate what can be enumerated
-> You should not belistin here anything except the last one andmaybe docs and
license. All others *have to be * gatehered by mvn_isntall and thus used via
"-f .mfiles"

Usage of .mfiles in the spec leads to :

Processing files: openjdk-asmtools-7.0.b10.pre.0.1-1.fc33.noarch
error: Could not open %files file ~/rpmbuild/BUILD/asmtools-master/.mfiles: No
such file or directory

Spec file change:
' ' '
%install
rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT%{_bindir}/
pushd maven
install -m 755 %{SOURCE1} $RPM_BUILD_ROOT%{_bindir}/
%mvn_install

%files -f .mfiles
%license LICENSE
%doc README.md
%attr(755, root, -) %{_bindir}/openjdk-asmtools
' ' '

So far I am not getting what is problem here!
Do you see anything obvious mistake here?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux