https://bugzilla.redhat.com/show_bug.cgi?id=1908526 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Flags|fedora-review? |fedora-review+ --- Comment #9 from code@xxxxxxxxxxxxxxxxxx --- > So I've created this PR, which is now merged: Thank you! > Basically, upstream's TornadoScopeManager is useful for contexts with > a Tornado 4 or 5 based on gen.coroutine. With Tornado 5 or 6 based on > async/await, the correct ScopeManager would rather be > ContextVarsScopeManager. TornadoScopeManager cannot even be imported > with Tornado 6. As long as upstream wants to support older Tornados > based on gen.coroutine, they won't delete TornadoScopeManager. > > But that's basically a question for users of the opentracing library, > who should make the correct choice. For building this package, the > only impact is a few sphinx warnings. Makes sense. > The error using sphinx seems to be some race condition due to the use > of %make_build which inserts a -j12. I've removed it, and now it > works correctly. Non-parallel-safe Makefiles are frustrating. I’m glad you figured it out. You can also do # Makefile is not safe for parallel builds %make_build -j1 and the -j1 will override the previous -j#. Or, if no make invocations in the spec file are safe to parallelize, you can do %global _smp_mflags %{nil} What you did is fine, though. > I think I have now fixed all reported issues and remarks. I agree! Approved, with full re-review below. Good luck finding a sponsor. I have blocked the FE-NEEDSPONSOR bug to bring attention to this review. In the unlikely case you’re still looking for a sponsor in a couple of months, feel free to contact me. I should be able to successfully apply for sponsor status then, and would be happy to sponsor you at that time based on this review alone. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Texinfo files are installed using install-info in %post and %preun if package has .info files. Note: Texinfo .info file(s) in python3-opentracing See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_texinfo This is a fedora-review bug, fixed by a PR from the submitter (thanks!) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0", "Expat License". 70 files have unknown license. Detailed output of licensecheck in /home/reviewer/1908526-python- opentracing/20210226/1908526-python-opentracing/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-opentracing [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-opentracing-2.4.0-1.fc35.noarch.rpm python-opentracing-doc-2.4.0-1.fc35.noarch.rpm python-opentracing-2.4.0-1.fc35.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/opentracing/opentracing-python/archive/2.4.0.tar.gz : CHECKSUM(SHA256) this package : 55ee4afc1f58cdc7d6c40bcc7f51568099619c1ef2cb78ddfd5c2cff871a500d CHECKSUM(SHA256) upstream package : 55ee4afc1f58cdc7d6c40bcc7f51568099619c1ef2cb78ddfd5c2cff871a500d Requires -------- python3-opentracing (rpmlib, GLIBC filtered): python(abi) python-opentracing-doc (rpmlib, GLIBC filtered): Provides -------- python3-opentracing: python-opentracing python3-opentracing python3.9-opentracing python3.9dist(opentracing) python3dist(opentracing) python-opentracing-doc: python-opentracing-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1908526 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: SugarActivity, fonts, PHP, Haskell, C/C++, R, Perl, Java, Ocaml, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
