https://bugzilla.redhat.com/show_bug.cgi?id=1929991 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > Source0: https://github.com/facelessuser/backrefs/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz This can be simplified to: Source0: https://github.com/facelessuser/backrefs/archive/%{version}/%{name}-%{version}.tar.gz Or even: Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz > Requires: python3dist(regex) Why is this needed? I see there is an extra called "extras" that requires regex: $ pip install 'backrefs[extras]' Requirement already satisfied: backrefs[extras] in ./__venv_tmp__/lib/python3.9/site-packages (5.0.1) Collecting regex; extra == "extras" Using cached regex-2020.11.13-cp39-cp39-manylinux2014_x86_64.whl (732 kB) Installing collected packages: regex Successfully installed regex-2020.11.13 I suggest following this: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_extras i.e. adding: %{?python_extras_subpkg:%python_extras_subpkg -n python3-%{pypi_name} -i %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info extras} Then, the dependent packages can require python3.Xdist(backrefs[extras]) if needed. Instead now, the package always requires regex and there is no provide for python3.Xdist(backrefs[extras]). > # Remove bundled egg-info > rm -rf %{pypi_name}.egg-info This is not needed, there is no egg-info in the github tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
