https://bugzilla.redhat.com/show_bug.cgi?id=1927011 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |crobinso@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Cole Robinson <crobinso@xxxxxxxxxx> --- Looks good to me, setting fedora-review+. Only things I noticed worth commenting on: Generic: [ ]: Changelog in prescribed format. The changelog timestamp is new to me, and it's not listed as an acceptable form in the packaging guidelines, so please fix that before pushing. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs Rpmlint ------- rust-sev-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/sev-0.1.0/.cargo-checksum.json Seems common in other rust packages so I think it's fine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
