https://bugzilla.redhat.com/show_bug.cgi?id=1929789 --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Jan Žerdík from comment #1) Thanks for the review. > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - uncomment licence directive in spec (resolved in upstream) It was added recently,it wasn't in the 3.9.0 version. Moreover it seems the versioning changed it's now 1.0.0, not 3.9.0. I updated the package. I guess the version changed due to https://github.com/dl1ksv/gr-funcube/issues/2 > - source cannot be downloaded It seems related to the previous problem, upstream removed the 3.9.0 tag, it's now 1.0.0, fixed. > - not owned directory /usr/lib64/cmake/funcube It should own the funcube directory (fixed), but I think it shouldn't own the /usr/lib64/cmake nor it should require package providing it: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function > - _udevrulesdir macro? It's good tip, fixed. > - big data in /usr/share from arched pkgs? Regarding the doc subpackage it should be noarch, but due to the bug in doxygen, the documentation is generated with different hashes and timestamps on different architectures which causes the build to fail (noarch packages are built on all architectures and then rpmdiffed). As a workaround the doc package must be arch. > - warnings in rpmlint? I think there should be only obsolete. It doesn't provide gr-fcdproplus, it's not drop-in replacement, so manual intervention is needed during upgrade. I also dropped probably unneeded workaround for rpmlint warning regarding unused libraries. New version (I dropped the changelog, because I don't want to introduce Epoch): Spec URL: https://jskarvad.fedorapeople.org/gr-funcube/gr-funcube.spec SRPM URL: https://jskarvad.fedorapeople.org/gr-funcube/gr-funcube-1.0.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
