https://bugzilla.redhat.com/show_bug.cgi?id=1912120 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from code@xxxxxxxxxxxxxxxxxx --- I’m glad to see you have correctly handled the bundled dependencies in the License field. You still need to follow https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling: if upstream does not support building against an external/system version of the bundled dependencies, you must contact them publicly about a path to doing so, and you must add the appropriate virtual Provides to indicate the bundling. The latest version is 1.7.0, and it has additional bundled dependencies which you must also handle. Since this is a GUI application, you need a desktop file (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files). If upstream does not provide one, you must write one. You should (not must, but should) also write an AppData XML file (https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/). It makes sense to offer both of these upstream. When ignoring format-security warnings, you should comment on whether you think they are spurious, and if not, why not. Or, report them upstream and let upstream decide, and link the bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
