[Bug 1923779] Review Request: catalyst -

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1923779

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
> Originally, Catalyst was part of ParaView. However, with ParaView version
> 5.9, the Catalyst API was revamped quite extensively and release as an
> independent project. This repository includes the definition together with a
> lightweight implementation of this revamped Catalyst API.
>
> The documentation describing the details, including build instructions and
> how to use Catalyst for in situ analysis and visualization in simulations is
> available here: https://catalyst-in-situ.readthedocs.io/en/latest/index.html

"d" is missing. But alltogether, this is not very intesting for users. Maybe:

Catalyst has been split out of ParaView. This package includes the definition
together with a
lightweight implementation of this Catalyst API.

For details how to use Catalyst for in situ analysis and visualization in
simulations,
see https://catalyst-in-situ.readthedocs.io/en/latest/index.html.

+ pakcage name is OK
+ license is acceptable for Fedora (BSD 3-clause)
+ license is specified correctly
+ builds and installs OK
+ BR look correct
+ P:bundled() is used where appropriate
+ P/R look correct

rpmlint:
catalyst.src: W: spelling-error Summary(en_US) situ -> sit, suit, site
catalyst.src: W: spelling-error %description -l en_US situ -> sit, suit, site
catalyst.src: W: strange-permission
catalyst-2fc94c55ba4eb994f27728141ebcf15c3435f306.tar.gz 660
catalyst.src: W: strange-permission catalyst-unbundle.patch 660
catalyst.src: W: strange-permission catalyst.spec 660
catalyst.src:24: W: unversioned-explicit-provides bundled(conduit)
catalyst.x86_64: W: spelling-error Summary(en_US) situ -> sit, suit, site
catalyst.x86_64: W: spelling-error %description -l en_US situ -> sit, suit,
site
catalyst.x86_64: W: no-documentation
catalyst-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 10 warnings.
Nothing important here.

Package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux