https://bugzilla.redhat.com/show_bug.cgi?id=1930954 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= The license tag does not match the content. Licensecheck output: *No copyright* GNU General Public License v2.0 or later ------------------------------------------------------- aexpect-1.6.1/aexpect/__init__.py aexpect-1.6.1/aexpect/exceptions.py aexpect-1.6.1/aexpect/shared.py aexpect-1.6.1/aexpect/utils/astring.py aexpect-1.6.1/aexpect/utils/data_factory.py aexpect-1.6.1/aexpect/utils/genio.py aexpect-1.6.1/aexpect/utils/path.py aexpect-1.6.1/aexpect/utils/process.py aexpect-1.6.1/aexpect/utils/wait.py aexpect-1.6.1/scripts/aexpect_helper GNU General Public License v2.0 only ------------------------------------ aexpect-1.6.1/debian/copyright GNU General Public License v2.0 or later ---------------------------------------- aexpect-1.6.1/aexpect/client.py aexpect-1.6.1/aexpect/remote.py aexpect-1.6.1/aexpect/remote_door.py aexpect-1.6.1/aexpect/rss_client.py aexpect-1.6.1/setup.py aexpect-1.6.1/tests/test_client.py aexpect-1.6.1/tests/test_pass_fds.py aexpect-1.6.1/tests/test_remote_door.py GNU General Public License, Version 2 ------------------------------------- aexpect-1.6.1/LICENSE Unknown or generated -------------------- aexpect-1.6.1/.travis.yml aexpect-1.6.1/Makefile aexpect-1.6.1/README.rst aexpect-1.6.1/debian/changelog aexpect-1.6.1/debian/compat aexpect-1.6.1/debian/control aexpect-1.6.1/debian/pyversions aexpect-1.6.1/debian/rules aexpect-1.6.1/debian/source/format aexpect-1.6.1/debian/source/options aexpect-1.6.1/debian/watch aexpect-1.6.1/python-aexpect.spec aexpect-1.6.1/requirements-travis.txt --- rpmlint issues (justified): python3-aexpect.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/aexpect/rss_client.py 644 /usr/bin/python Suggestions and tips: ===================== Remove `Requires: python3` (see above). --- You can change: Source0: https://github.com/avocado-framework/%{srcname}/archive/%{version}.tar.gz#/%{gittar} Source0: https://github.com/avocado-framework/%{srcname}/archive/%{commit}.tar.gz#/%{gittar} To: Source0: https://github.com/avocado-framework/%{srcname}/archive/%{version}/%{gittar} Source0: https://github.com/avocado-framework/%{srcname}/archive/%{commit}/%{gittar} Or even: Source0: https://github.com/avocado-framework/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz Source0: https://github.com/avocado-framework/%{srcname}/archive/%{commit}/%{srcname}-%{shortcommit}.tar.gz Or even: Source0: %{url}/archive/%{version}/%{srcname}-%{version}.tar.gz Source0: %{url}/archive/%{commit}/%{srcname}-%{shortcommit}.tar.gz --- If you change: %check %if %{with_tests} selftests/checkall %endif To: %if %{with_tests} %check selftests/checkall %endif There will be no empty %check section in the log that could be confusing to the log reader (it was to me). --- If you change: %{python3_sitelib}/aexpect-%{version}-py%{python3_version}.egg-info To: %{python3_sitelib}/aexpect-%{version}-py%{python3_version}.egg-info/ rpmbuild will assert this is a directory and a specfile reader will know it is a directory just by reading it. (I've seen cases when egg-info was a directory or a file depending on the content of the buildroot and upgrading from a directory to a file breaks RPM.) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 or later", "GNU General Public License v2.0 only". 13 files have unknown license. Detailed output of licensecheck in /home/churchyard/rpmbuild/FedoraReview/1930954-python- aexpect/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-aexpect-1.6.1-1.fc35.noarch.rpm python-aexpect-1.6.1-1.fc35.src.rpm python3-aexpect.noarch: W: spelling-error %description -l en_US pexpect -> expect, p expect python3-aexpect.noarch: W: spelling-error %description -l en_US scp -> cps, sci, sip python3-aexpect.noarch: W: spelling-error %description -l en_US sftp -> ftp, ftps, s ftp python3-aexpect.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/aexpect/rss_client.py 644 /usr/bin/python python3-aexpect.noarch: W: no-manual-page-for-binary aexpect_helper python3-aexpect.noarch: W: no-manual-page-for-binary aexpect_helper-3 python3-aexpect.noarch: W: no-manual-page-for-binary aexpect_helper-3.9 python-aexpect.src: W: spelling-error %description -l en_US pexpect -> expect, p expect python-aexpect.src: W: spelling-error %description -l en_US scp -> cps, sci, sip python-aexpect.src: W: spelling-error %description -l en_US sftp -> ftp, ftps, s ftp 2 packages and 0 specfiles checked; 1 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- python3-aexpect.noarch: W: spelling-error %description -l en_US pexpect -> expect, p expect python3-aexpect.noarch: W: spelling-error %description -l en_US scp -> cps, sci, sip python3-aexpect.noarch: W: spelling-error %description -l en_US sftp -> ftp, ftps, s ftp python3-aexpect.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/aexpect/rss_client.py 644 /usr/bin/python python3-aexpect.noarch: W: no-manual-page-for-binary aexpect_helper python3-aexpect.noarch: W: no-manual-page-for-binary aexpect_helper-3 python3-aexpect.noarch: W: no-manual-page-for-binary aexpect_helper-3.9 1 packages and 0 specfiles checked; 1 errors, 6 warnings. Source checksums ---------------- https://github.com/avocado-framework/aexpect/archive/1.6.1.tar.gz#/aexpect-1.6.1.tar.gz : CHECKSUM(SHA256) this package : 40437382f7c4c273dbe45013fca8e7e5e0344eba332dc3aa0c59cc2e2aa67136 CHECKSUM(SHA256) upstream package : 40437382f7c4c273dbe45013fca8e7e5e0344eba332dc3aa0c59cc2e2aa67136 Requires -------- python3-aexpect (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-aexpect: python-aexpect python3-aexpect python3.9-aexpect python3.9dist(aexpect) python3dist(aexpect) Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 1930954 -m fedora-rawhide-x86_64 --mock-options=--enablerepo=local Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Ruby, Java, fonts, PHP, C/C++, Perl, SugarActivity, R, Ocaml, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
