https://bugzilla.redhat.com/show_bug.cgi?id=1928654 Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> --- Spec file looks fine - tt follows packaging guidelines, including Java guidelines. Source code it the SRPM matches upstream code. Package builds fine in rawhide. Buildrequires are correct, except that BR on maven-enforcer-plugin seems to be unnecessary and it can be removed. Auto-requires are generated, manual requires are absent. rpmlint output: ongres-stringprep.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. The code is licensed under BSD license, which matches License tag in spec file. License text is installed as %license. License review reveals references to ASL 2.0 license, but it only applies to external dependency (Apache Velocity), which is not bundled in the package. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure