https://bugzilla.redhat.com/show_bug.cgi?id=1920754 --- Comment #8 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to dan.cermak from comment #4) > Looks good to me overall, only a few minor things: > > - upstream publishes gpg signatures, consider using gpgverify > - the source contains not only isc licensed files, but BSD 3 clause and 2 > clause as well (both in libopenbsd/) > - consider declaring libopenbsd as a bundled dependency Thanks for the review, I have fixed all aforementioned points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure