https://bugzilla.redhat.com/show_bug.cgi?id=1912914 Cestmir Kalina <ckalina@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@xxxxxxxx | |m) --- Comment #9 from Cestmir Kalina <ckalina@xxxxxxxxxx> --- Thank you for the reply. (In reply to Neal Gompa from comment #8) > This package doesn't comply with the Python packaging guidelines: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > > Some things I see that's wrong with it: > > * Dependency generators are disabled, which is not something we generally > permit. The guideline states "Packages MAY use the automatic Python dependency generator." and "This generator is enabled by default in Fedora. If a packager wishes to explicitly opt out of the generator because the upstream metadata are not applicable, a packager SHOULD opt out explicitly by adding: %{?python_disable_dependency_generator}" This macro is not present in the spec file. Added egg-info. Using py3_dist. > * The usage of %__python is not permitted Removed. > * This should use the %py3_build and %py3_install macros instead of calling > setup.py manually Changed. > * URL does not point to the project home page Changed to point to github page of the project. Do you figure there's anything missing? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
