https://bugzilla.redhat.com/show_bug.cgi?id=1928111 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: 97dfa79a309a086e184a4e61047f8a10ffb3db051025e7d222a25f19130ba417) is orginal. Ok. Summary verified from lib/Crypt/PBKDF2.pm. Ok. Description verified from lib/Crypt/PBKDF2.pm. Ok. License verified from LICENSE, lib/Crypt/PBKDF2.pm, lib/Crypt/PBKDF2/Hash/HMACSHA2.pm, lib/Crypt/PBKDF2/Hash/DigestHMAC.pm, lib/Crypt/PBKDF2/Hash/HMACSHA3.pm, lib/Crypt/PBKDF2/Hash/HMACSHA1.pm, lib/Crypt/PBKDF2/Hash.pm, and Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. TODO: Remove findutils from BuildRequires. I think it's not used anywhere. All tests pass. Ok. $ rpmlint perl-Crypt-PBKDF2.spec ../SRPMS/perl-Crypt-PBKDF2-0.161520-2.fc35.src.rpm ../RPMS/noarch/perl-Crypt-PBKDF2-0.161520-2.fc35.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Crypt-PBKDF2-0.161520-2.fc35.noarch.rpm drwxr-xr-x 2 root root 0 Feb 15 09:32 /usr/share/doc/perl-Crypt-PBKDF2 -rw-r--r-- 1 root root 2338 May 31 2016 /usr/share/doc/perl-Crypt-PBKDF2/Changes drwxr-xr-x 2 root root 0 Feb 15 09:32 /usr/share/licenses/perl-Crypt-PBKDF2 -rw-r--r-- 1 root root 18355 May 31 2016 /usr/share/licenses/perl-Crypt-PBKDF2/LICENSE -rw-r--r-- 1 root root 3963 Feb 15 09:32 /usr/share/man/man3/Crypt::PBKDF2.3pm.gz -rw-r--r-- 1 root root 1755 Feb 15 09:32 /usr/share/man/man3/Crypt::PBKDF2::Hash.3pm.gz -rw-r--r-- 1 root root 1498 Feb 15 09:32 /usr/share/man/man3/Crypt::PBKDF2::Hash::DigestHMAC.3pm.gz -rw-r--r-- 1 root root 1396 Feb 15 09:32 /usr/share/man/man3/Crypt::PBKDF2::Hash::HMACSHA1.3pm.gz -rw-r--r-- 1 root root 1414 Feb 15 09:32 /usr/share/man/man3/Crypt::PBKDF2::Hash::HMACSHA2.3pm.gz -rw-r--r-- 1 root root 1475 Feb 15 09:32 /usr/share/man/man3/Crypt::PBKDF2::Hash::HMACSHA3.3pm.gz drwxr-xr-x 2 root root 0 Feb 15 09:32 /usr/share/perl5/vendor_perl/Crypt drwxr-xr-x 2 root root 0 Feb 15 09:32 /usr/share/perl5/vendor_perl/Crypt/PBKDF2 -rw-r--r-- 1 root root 14515 May 31 2016 /usr/share/perl5/vendor_perl/Crypt/PBKDF2.pm drwxr-xr-x 2 root root 0 Feb 15 09:32 /usr/share/perl5/vendor_perl/Crypt/PBKDF2/Hash -rw-r--r-- 1 root root 1541 May 31 2016 /usr/share/perl5/vendor_perl/Crypt/PBKDF2/Hash.pm -rw-r--r-- 1 root root 1921 May 31 2016 /usr/share/perl5/vendor_perl/Crypt/PBKDF2/Hash/DigestHMAC.pm -rw-r--r-- 1 root root 1084 May 31 2016 /usr/share/perl5/vendor_perl/Crypt/PBKDF2/Hash/HMACSHA1.pm -rw-r--r-- 1 root root 1650 May 31 2016 /usr/share/perl5/vendor_perl/Crypt/PBKDF2/Hash/HMACSHA2.pm -rw-r--r-- 1 root root 1844 May 31 2016 /usr/share/perl5/vendor_perl/Crypt/PBKDF2/Hash/HMACSHA3.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-PBKDF2-0.161520-2.fc35.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(Carp) 1 perl(Digest) >= 1.16 1 perl(Digest::HMAC) >= 1.01 1 perl(Digest::SHA) 1 perl(Digest::SHA3) >= 0.22 1 perl(MIME::Base64) 1 perl(Module::Runtime) 1 perl(Moo) >= 2 1 perl(Moo::Role) >= 2 1 perl(namespace::autoclean) 1 perl(Scalar::Util) 1 perl(strictures) >= 2 1 perl(Try::Tiny) >= 0.04 1 perl(Type::Tiny) 1 perl(Types::Standard) >= 1.000005 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Crypt-PBKDF2-0.161520-2.fc35.noarch.rpm | sort -f | uniq -c 1 perl(Crypt::PBKDF2) = 0.161520 1 perl(Crypt::PBKDF2::Hash) = 0.161520 1 perl(Crypt::PBKDF2::Hash::DigestHMAC) = 0.161520 1 perl(Crypt::PBKDF2::Hash::HMACSHA1) = 0.161520 1 perl(Crypt::PBKDF2::Hash::HMACSHA2) = 0.161520 1 perl(Crypt::PBKDF2::Hash::HMACSHA3) = 0.161520 1 perl-Crypt-PBKDF2 = 0.161520-2.fc35 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Crypt-PBKDF2-0.161520-2.fc35.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=61984975). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the TODO item before building the package. Resolution: Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
