https://bugzilla.redhat.com/show_bug.cgi?id=1927444 --- Comment #1 from Jan Staněk <jstanek@xxxxxxxxxx> --- Mostly looks good, but this one definitely deserves separate -docs subpackage. Once that is fixed, it should be good to go. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3706880 bytes in 656 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4659200 bytes in /usr/share Note: Probably related to the -docs subpackage [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-luv-0.5.6-1.fc35.x86_64.rpm ocaml-luv-devel-0.5.6-1.fc35.x86_64.rpm ocaml-luv-debuginfo-0.5.6-1.fc35.x86_64.rpm ocaml-luv-debugsource-0.5.6-1.fc35.x86_64.rpm ocaml-luv-0.5.6-1.fc35.src.rpm ocaml-luv.x86_64: W: spelling-error Summary(en_US) libuv -> lib ocaml-luv.x86_64: W: spelling-error %description -l en_US libuv -> lib ocaml-luv.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j ocaml-luv.x86_64: W: spelling-error %description -l en_US multithreading -> multitasking ocaml-luv.x86_64: W: spelling-error %description -l en_US Libuv -> Malibu ocaml-luv.src: W: spelling-error Summary(en_US) libuv -> lib ocaml-luv.src: W: spelling-error %description -l en_US libuv -> lib ocaml-luv.src: W: spelling-error %description -l en_US js -> dis, ks, j ocaml-luv.src: W: spelling-error %description -l en_US multithreading -> multitasking ocaml-luv.src: W: spelling-error %description -l en_US Libuv -> Malibu 5 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: ocaml-luv-debuginfo-0.5.6-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- ocaml-luv.x86_64: W: spelling-error Summary(en_US) libuv -> lib ocaml-luv.x86_64: W: spelling-error %description -l en_US libuv -> lib ocaml-luv.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j ocaml-luv.x86_64: W: spelling-error %description -l en_US multithreading -> multitasking ocaml-luv.x86_64: W: spelling-error %description -l en_US Libuv -> Malibu 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Unversioned so-files -------------------- ocaml-luv: /usr/lib64/ocaml/stublibs/dllluv_c_stubs.so Source checksums ---------------- https://github.com/aantron/luv/releases/download/0.5.6/luv-0.5.6.tar.gz : CHECKSUM(SHA256) this package : 35d8092d7a7e8d00a7ab8caf79d99e2073baf1999f5b9274de4d69078ad83685 CHECKSUM(SHA256) upstream package : 35d8092d7a7e8d00a7ab8caf79d99e2073baf1999f5b9274de4d69078ad83685 Requires -------- ocaml-luv (rpmlib, GLIBC filtered): libc.so.6()(64bit) libuv.so.1()(64bit) ocaml(Bigarray_compat) ocaml(CamlinternalFormatBasics) ocaml(ComplexL) ocaml(Cstubs_internals) ocaml(Ctypes) ocaml(Ctypes_bigarray) ocaml(Ctypes_memory_stubs) ocaml(Ctypes_primitive_types) ocaml(Ctypes_ptr) ocaml(Ctypes_static) ocaml(Ctypes_types) ocaml(LDouble) ocaml(Luv__) ocaml(Luv__Buffer) ocaml(Luv__C) ocaml(Luv__Compatibility) ocaml(Luv__Env) ocaml(Luv__Error) ocaml(Luv__File) ocaml(Luv__Handle) ocaml(Luv__Helpers) ocaml(Luv__Loop) ocaml(Luv__Loop_watcher) ocaml(Luv__Mutex) ocaml(Luv__Os_fd) ocaml(Luv__Pipe) ocaml(Luv__Request) ocaml(Luv__Sockaddr) ocaml(Luv__Stream) ocaml(Luv__TCP) ocaml(Luv_c_function_descriptions) ocaml(Luv_c_generated_functions) ocaml(Luv_c_generated_types) ocaml(Luv_c_type_descriptions) ocaml(Luv_c_types) ocaml(PosixTypes) ocaml(Result) ocaml(Signed) ocaml(Stdlib) ocaml(Stdlib__array) ocaml(Stdlib__bigarray) ocaml(Stdlib__buffer) ocaml(Stdlib__bytes) ocaml(Stdlib__complex) ocaml(Stdlib__format) ocaml(Stdlib__int32) ocaml(Stdlib__list) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__result) ocaml(Stdlib__seq) ocaml(Stdlib__string) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Unsigned) ocamlx(Cstubs_internals) ocamlx(PosixTypes) ocamlx(Stdlib) ocamlx(Stdlib__array) ocamlx(Stdlib__bigarray) ocamlx(Stdlib__bytes) ocamlx(Stdlib__list) ocamlx(Stdlib__nativeint) ocamlx(Stdlib__printexc) ocamlx(Stdlib__printf) ocamlx(Stdlib__string) ocamlx(Stdlib__sys) rtld(GNU_HASH) ocaml-luv-devel (rpmlib, GLIBC filtered): ocaml(Bigarray_compat) ocaml(CamlinternalFormatBasics) ocaml(ComplexL) ocaml(Cstubs_internals) ocaml(Ctypes) ocaml(Ctypes_bigarray) ocaml(Ctypes_memory_stubs) ocaml(Ctypes_primitive_types) ocaml(Ctypes_ptr) ocaml(Ctypes_static) ocaml(Ctypes_types) ocaml(LDouble) ocaml(Luv__) ocaml(Luv__Buffer) ocaml(Luv__C) ocaml(Luv__Compatibility) ocaml(Luv__Env) ocaml(Luv__Error) ocaml(Luv__File) ocaml(Luv__Handle) ocaml(Luv__Helpers) ocaml(Luv__Loop) ocaml(Luv__Loop_watcher) ocaml(Luv__Mutex) ocaml(Luv__Os_fd) ocaml(Luv__Pipe) ocaml(Luv__Request) ocaml(Luv__Sockaddr) ocaml(Luv__Stream) ocaml(Luv__TCP) ocaml(Luv_c_function_descriptions) ocaml(Luv_c_generated_functions) ocaml(Luv_c_generated_types) ocaml(Luv_c_type_descriptions) ocaml(Luv_c_types) ocaml(PosixTypes) ocaml(Result) ocaml(Signed) ocaml(Stdlib) ocaml(Stdlib__array) ocaml(Stdlib__bigarray) ocaml(Stdlib__buffer) ocaml(Stdlib__bytes) ocaml(Stdlib__complex) ocaml(Stdlib__format) ocaml(Stdlib__int32) ocaml(Stdlib__list) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__result) ocaml(Stdlib__seq) ocaml(Stdlib__string) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Unsigned) ocaml-ctypes-devel(x86-64) ocaml-luv(x86-64) ocaml-result-devel(x86-64) ocamlx(Cstubs_internals) ocamlx(PosixTypes) ocamlx(Stdlib) ocamlx(Stdlib__array) ocamlx(Stdlib__bigarray) ocamlx(Stdlib__bytes) ocamlx(Stdlib__list) ocamlx(Stdlib__nativeint) ocamlx(Stdlib__printexc) ocamlx(Stdlib__printf) ocamlx(Stdlib__string) ocamlx(Stdlib__sys) ocaml-luv-debuginfo (rpmlib, GLIBC filtered): ocaml-luv-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-luv: ocaml(Luv) ocaml(Luv__) ocaml(Luv__Async) ocaml(Luv__Barrier) ocaml(Luv__Buffer) ocaml(Luv__C) ocaml(Luv__Check) ocaml(Luv__Compatibility) ocaml(Luv__Condition) ocaml(Luv__DLL) ocaml(Luv__DNS) ocaml(Luv__Env) ocaml(Luv__Error) ocaml(Luv__FS_event) ocaml(Luv__FS_poll) ocaml(Luv__File) ocaml(Luv__Handle) ocaml(Luv__Helpers) ocaml(Luv__Idle) ocaml(Luv__Loop) ocaml(Luv__Loop_watcher) ocaml(Luv__Metrics) ocaml(Luv__Mutex) ocaml(Luv__Network) ocaml(Luv__Once) ocaml(Luv__Os_fd) ocaml(Luv__Passwd) ocaml(Luv__Path) ocaml(Luv__Pid) ocaml(Luv__Pipe) ocaml(Luv__Poll) ocaml(Luv__Prepare) ocaml(Luv__Process) ocaml(Luv__Random) ocaml(Luv__Request) ocaml(Luv__Resource) ocaml(Luv__Rwlock) ocaml(Luv__Semaphore) ocaml(Luv__Signal) ocaml(Luv__Sockaddr) ocaml(Luv__Stream) ocaml(Luv__System_info) ocaml(Luv__TCP) ocaml(Luv__TLS) ocaml(Luv__TTY) ocaml(Luv__Thread) ocaml(Luv__Thread_pool) ocaml(Luv__Time) ocaml(Luv__Timer) ocaml(Luv__UDP) ocaml(Luv__Version) ocaml(Luv_c_function_descriptions) ocaml(Luv_c_generated_functions) ocaml(Luv_c_generated_types) ocaml(Luv_c_type_descriptions) ocaml(Luv_c_types) ocaml-luv ocaml-luv(x86-64) ocamlx(Luv) ocamlx(Luv__) ocamlx(Luv__Async) ocamlx(Luv__Barrier) ocamlx(Luv__Buffer) ocamlx(Luv__C) ocamlx(Luv__Check) ocamlx(Luv__Compatibility) ocamlx(Luv__Condition) ocamlx(Luv__DLL) ocamlx(Luv__DNS) ocamlx(Luv__Env) ocamlx(Luv__Error) ocamlx(Luv__FS_event) ocamlx(Luv__FS_poll) ocamlx(Luv__File) ocamlx(Luv__Handle) ocamlx(Luv__Helpers) ocamlx(Luv__Idle) ocamlx(Luv__Loop) ocamlx(Luv__Loop_watcher) ocamlx(Luv__Metrics) ocamlx(Luv__Mutex) ocamlx(Luv__Network) ocamlx(Luv__Once) ocamlx(Luv__Os_fd) ocamlx(Luv__Passwd) ocamlx(Luv__Path) ocamlx(Luv__Pid) ocamlx(Luv__Pipe) ocamlx(Luv__Poll) ocamlx(Luv__Prepare) ocamlx(Luv__Process) ocamlx(Luv__Random) ocamlx(Luv__Request) ocamlx(Luv__Resource) ocamlx(Luv__Rwlock) ocamlx(Luv__Semaphore) ocamlx(Luv__Signal) ocamlx(Luv__Sockaddr) ocamlx(Luv__Stream) ocamlx(Luv__System_info) ocamlx(Luv__TCP) ocamlx(Luv__TLS) ocamlx(Luv__TTY) ocamlx(Luv__Thread) ocamlx(Luv__Thread_pool) ocamlx(Luv__Time) ocamlx(Luv__Timer) ocamlx(Luv__UDP) ocamlx(Luv__Version) ocamlx(Luv_c_function_descriptions) ocamlx(Luv_c_generated_functions) ocamlx(Luv_c_generated_types) ocamlx(Luv_c_type_descriptions) ocamlx(Luv_c_types) ocaml-luv-devel: ocaml(Luv) ocaml(Luv__) ocaml(Luv__Async) ocaml(Luv__Barrier) ocaml(Luv__Buffer) ocaml(Luv__C) ocaml(Luv__Check) ocaml(Luv__Compatibility) ocaml(Luv__Condition) ocaml(Luv__DLL) ocaml(Luv__DNS) ocaml(Luv__Env) ocaml(Luv__Error) ocaml(Luv__FS_event) ocaml(Luv__FS_poll) ocaml(Luv__File) ocaml(Luv__Handle) ocaml(Luv__Helpers) ocaml(Luv__Idle) ocaml(Luv__Loop) ocaml(Luv__Loop_watcher) ocaml(Luv__Metrics) ocaml(Luv__Mutex) ocaml(Luv__Network) ocaml(Luv__Once) ocaml(Luv__Os_fd) ocaml(Luv__Passwd) ocaml(Luv__Path) ocaml(Luv__Pid) ocaml(Luv__Pipe) ocaml(Luv__Poll) ocaml(Luv__Prepare) ocaml(Luv__Process) ocaml(Luv__Random) ocaml(Luv__Request) ocaml(Luv__Resource) ocaml(Luv__Rwlock) ocaml(Luv__Semaphore) ocaml(Luv__Signal) ocaml(Luv__Sockaddr) ocaml(Luv__Stream) ocaml(Luv__System_info) ocaml(Luv__TCP) ocaml(Luv__TLS) ocaml(Luv__TTY) ocaml(Luv__Thread) ocaml(Luv__Thread_pool) ocaml(Luv__Time) ocaml(Luv__Timer) ocaml(Luv__UDP) ocaml(Luv__Version) ocaml(Luv_c_function_descriptions) ocaml(Luv_c_generated_functions) ocaml(Luv_c_generated_types) ocaml(Luv_c_type_descriptions) ocaml(Luv_c_types) ocaml-luv-devel ocaml-luv-devel(x86-64) ocamlx(Luv) ocamlx(Luv__) ocamlx(Luv__Async) ocamlx(Luv__Barrier) ocamlx(Luv__Buffer) ocamlx(Luv__C) ocamlx(Luv__Check) ocamlx(Luv__Compatibility) ocamlx(Luv__Condition) ocamlx(Luv__DLL) ocamlx(Luv__DNS) ocamlx(Luv__Env) ocamlx(Luv__Error) ocamlx(Luv__FS_event) ocamlx(Luv__FS_poll) ocamlx(Luv__File) ocamlx(Luv__Handle) ocamlx(Luv__Helpers) ocamlx(Luv__Idle) ocamlx(Luv__Loop) ocamlx(Luv__Loop_watcher) ocamlx(Luv__Metrics) ocamlx(Luv__Mutex) ocamlx(Luv__Network) ocamlx(Luv__Once) ocamlx(Luv__Os_fd) ocamlx(Luv__Passwd) ocamlx(Luv__Path) ocamlx(Luv__Pid) ocamlx(Luv__Pipe) ocamlx(Luv__Poll) ocamlx(Luv__Prepare) ocamlx(Luv__Process) ocamlx(Luv__Random) ocamlx(Luv__Request) ocamlx(Luv__Resource) ocamlx(Luv__Rwlock) ocamlx(Luv__Semaphore) ocamlx(Luv__Signal) ocamlx(Luv__Sockaddr) ocamlx(Luv__Stream) ocamlx(Luv__System_info) ocamlx(Luv__TCP) ocamlx(Luv__TLS) ocamlx(Luv__TTY) ocamlx(Luv__Thread) ocamlx(Luv__Thread_pool) ocamlx(Luv__Time) ocamlx(Luv__Timer) ocamlx(Luv__UDP) ocamlx(Luv__Version) ocamlx(Luv_c_function_descriptions) ocamlx(Luv_c_generated_functions) ocamlx(Luv_c_generated_types) ocamlx(Luv_c_type_descriptions) ocamlx(Luv_c_types) ocaml-luv-debuginfo: debuginfo(build-id) ocaml-luv-debuginfo ocaml-luv-debuginfo(x86-64) ocaml-luv-debugsource: ocaml-luv-debugsource ocaml-luv-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -Ltmprepo -b 1927444 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api, Ocaml Disabled plugins: SugarActivity, fonts, Perl, Haskell, PHP, Java, Python, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
