https://bugzilla.redhat.com/show_bug.cgi?id=1926697 --- Comment #7 from jiri vanek <jvanek@xxxxxxxxxx> --- Please fix all [!] items and all rpmlint Errors, and some warings (eg the dot, but eg spell chekc is wrong and you are right) Maybe except "openjdk-asmtools.noarch: E: incorrect-fsf-address /usr/share/licenses/openjdk-asmtools/LICENSE" I'm not sure what it means, looks good to me. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 only". 5 files have unknown license. Detailed output of licensecheck in /home/jvanek/1926697-openjdk-asmtools/licensecheck.txt Afaik this is GPLv2 not LGPLv2 [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Please add version [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. You miss Requires java-headless. Please verify that jre is enough, and no jdk is needed. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/openjdk/openjdk- asmtools/archive/openjdk-asmtools-7.0.b10.pre.0.1.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ This is ok as there is no upstream release with maven bindings yet [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). See above [!]: Package functions as described. Please add launcher(s) openjdk-asmtools launcher is a must. openjdk-asmtools-{jasm,jdis,jcoder,jdec,jcdec} would be nice to have :) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define major 7.0, %define minor b09 Please try to fix this [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openjdk-asmtools-7.0.b10.pre.0.1-pre.0.1.noarch.rpm openjdk-asmtools-7.0.b10.pre.0.1-pre.0.1.src.rpm openjdk-asmtools.noarch: W: summary-ended-with-dot C An OpenSource project to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.noarch: E: summary-too-long C An OpenSource project to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.noarch: W: spelling-error %description -l en_US disassemblers -> disassembles, dis assemblers, dis-assemblers openjdk-asmtools.noarch: W: spelling-error %description -l en_US Jasm -> Jams, Jam, Jasmine openjdk-asmtools.noarch: W: spelling-error %description -l en_US JCod -> J Cod, Cod openjdk-asmtools.noarch: E: description-line-too-long C AsmTools OpenSource project which helps to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.noarch: E: description-line-too-long C Also, aids a community of Java .class file production for various testing and other OpenJDK development applications. openjdk-asmtools.noarch: E: description-line-too-long C Jasm/Jdis: an assembler language that provides a Java-like declaration of member signatures, openjdk-asmtools.noarch: E: description-line-too-long C while providing Java VM specification compliant mnemonics for byte-code instructions. openjdk-asmtools.noarch: E: description-line-too-long C JCod/JDec: an assembler language that provides byte-code containers of class-file constructs. openjdk-asmtools.noarch: E: description-line-too-long C AsmTools are developed to support the latest class file formats, in lock-step with JDK development. openjdk-asmtools.noarch: W: no-version-in-last-changelog openjdk-asmtools.noarch: W: invalid-url URL: https://github.com/openjdk/openjdk-asmtools HTTP Error 404: Not Found openjdk-asmtools.noarch: E: incorrect-fsf-address /usr/share/licenses/openjdk-asmtools/LICENSE openjdk-asmtools.src: W: summary-ended-with-dot C An OpenSource project to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.src: E: summary-too-long C An OpenSource project to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.src: W: spelling-error %description -l en_US disassemblers -> disassembles, dis assemblers, dis-assemblers openjdk-asmtools.src: W: spelling-error %description -l en_US Jasm -> Jams, Jam, Jasmine openjdk-asmtools.src: W: spelling-error %description -l en_US JCod -> J Cod, Cod openjdk-asmtools.src: E: description-line-too-long C AsmTools OpenSource project which helps to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.src: E: description-line-too-long C Also, aids a community of Java .class file production for various testing and other OpenJDK development applications. openjdk-asmtools.src: E: description-line-too-long C Jasm/Jdis: an assembler language that provides a Java-like declaration of member signatures, openjdk-asmtools.src: E: description-line-too-long C while providing Java VM specification compliant mnemonics for byte-code instructions. openjdk-asmtools.src: E: description-line-too-long C JCod/JDec: an assembler language that provides byte-code containers of class-file constructs. openjdk-asmtools.src: E: description-line-too-long C AsmTools are developed to support the latest class file formats, in lock-step with JDK development. openjdk-asmtools.src: W: no-version-in-last-changelog openjdk-asmtools.src: W: invalid-url URL: https://github.com/openjdk/openjdk-asmtools HTTP Error 404: Not Found openjdk-asmtools.src: W: inconsistent-file-extension openjdk-asmtools-7.0.b10.pre.0.1.tar.gz openjdk-asmtools.src:15: W: macro-in-comment %{name} openjdk-asmtools.src:15: W: macro-in-comment %{major} openjdk-asmtools.src:15: W: macro-in-comment %{minor} openjdk-asmtools.src:35: W: macro-in-comment %setup openjdk-asmtools.src:35: W: macro-in-comment %{version} openjdk-asmtools.src: E: specfile-error warning: Macro expanded in comment on line 15: %{name}/archive/%{major}-%{minor}.tar.gz openjdk-asmtools.src: E: specfile-error openjdk-asmtools.src: E: specfile-error warning: Macro expanded in comment on line 15: %{name}/archive/%{major}-%{minor}.tar.gz 2 packages and 0 specfiles checked; 18 errors, 18 warnings. Rpmlint (installed packages) ---------------------------- openjdk-asmtools.noarch: W: summary-ended-with-dot C An OpenSource project to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.noarch: E: summary-too-long C An OpenSource project to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.noarch: W: spelling-error %description -l en_US disassemblers -> disassembles, dis assemblers, dis-assemblers openjdk-asmtools.noarch: W: spelling-error %description -l en_US Jasm -> Jams, Jam, Jasmine openjdk-asmtools.noarch: W: spelling-error %description -l en_US JCod -> J Cod, Cod openjdk-asmtools.noarch: E: description-line-too-long C AsmTools OpenSource project which helps to develop tools for the production of proper and improper Java '.class' files. openjdk-asmtools.noarch: E: description-line-too-long C Also, aids a community of Java .class file production for various testing and other OpenJDK development applications. openjdk-asmtools.noarch: E: description-line-too-long C Jasm/Jdis: an assembler language that provides a Java-like declaration of member signatures, openjdk-asmtools.noarch: E: description-line-too-long C while providing Java VM specification compliant mnemonics for byte-code instructions. openjdk-asmtools.noarch: E: description-line-too-long C JCod/JDec: an assembler language that provides byte-code containers of class-file constructs. openjdk-asmtools.noarch: E: description-line-too-long C AsmTools are developed to support the latest class file formats, in lock-step with JDK development. openjdk-asmtools.noarch: W: no-version-in-last-changelog openjdk-asmtools.noarch: W: invalid-url URL: https://github.com/openjdk/openjdk-asmtools HTTP Error 404: Not Found openjdk-asmtools.noarch: E: incorrect-fsf-address /usr/share/licenses/openjdk-asmtools/LICENSE 1 packages and 0 specfiles checked; 8 errors, 6 warnings. Requires -------- openjdk-asmtools (rpmlib, GLIBC filtered): Provides -------- openjdk-asmtools: openjdk-asmtools Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1926697 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Python, Haskell, R, SugarActivity, Perl, PHP, Ocaml, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
