Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monit - Manages and monitors processes, files, directories and devices https://bugzilla.redhat.com/show_bug.cgi?id=369211 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-13 00:46 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But NOT for RPM. monit.i386: E: non-readable /etc/monit.conf 0600 monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog monit.i386: W: incoherent-subsys /etc/rc.d/init.d/monit $prog ==> looks ok to accept with these messages for this package. + source files match upstream url d3143b0bbd79b53f1b019d2fc1dae656 monit-4.10.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + services scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package monit-4.10.1-2.fc8.1 -> Provides: config(monit) = 4.10.1-2.fc8.1 Requires: /bin/bash config(monit) = 4.10.1-2.fc8.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcrypt.so.1 libcrypt.so.1(GLIBC_2.0) libcrypto.so.6 libnsl.so.1 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.2) libresolv.so.2 libssl.so.6 rtld(GNU_HASH) + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review