[Bug 1150105] Review Request: python-pynn - Simulator-independent specification of neuronal network models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1150105



--- Comment #12 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Thanks for the review Jerry. Apologies for the delay. Here are the updated
Spec/SRPM files:


Spec: https://ankursinha.fedorapeople.org/python-pynn/python-pynn.spec
SRPM:
https://ankursinha.fedorapeople.org/python-pynn/python-pynn-0.9.6-1.fc33.src.rpm

Changelog:

* Tue Feb 09 2021 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.9.6-1
- Remove duplicate neuron-devel BR
- Add patch to correct python operator usage
- Use arch dependent and version specific requirement on base package
- Add comment about NEURON files
- Filter out private libnrnmech from provides

The rpath bit came from the NEURON package. I've fixed that and pushed updates
too. So if you test this one for F32/F33, you'll have to ensure that the
updates-testing repo is enabled for the build.

I've submitted a PR for the python issue, which was already accepted:
https://github.com/NeuralEnsemble/PyNN/pull/706

I've also filed a ticket for the compilation warnings:
https://github.com/NeuralEnsemble/PyNN/issues/707

The x86_64 folder is NEURON specific. Mod files that are to be accessible in
NEURON are compiled together to create a libnrnmech.so library, which is loaded
into NEURON by a script called "special" (that calls `nrniv -dll
$ARCH/.libs/libnrnmech.so`). And then, `.libs/libnrnmech.so` is a sym link to
`../../$ARCH/libnrnmech.so`. I guess they could just use the libnrnmech.so file
instead of the symlink, but this is how it is---probably because of some
historical reasons. It also creates the empty x86_64 directory as you noticed:
really not sure what that is about but I see it everywhere we compile mod
files. I'll double check with colleagues that are running NEURON on other
platforms to see if this one is necessary and also confirm with upstream.

Cheers,
Ankur


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux