[Bug 1917089] Review Request: python-doubleratchet - Python implementation of the Double Ratchet algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1917089

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
The version specified in the package should match the actual version of the
code.
Thus, you should have
(https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_prerelease_versions)

Version:        0.7.0~beta
...
Source0:       
https://github.com/Syndace/%{name}/archive/v%{version_no_tilde}.tar.gz
%global version_main %(c=%version; echo $c|cut -d~ -f1)
...
%prep
%autosetup -n %{name}-%{version_no_tilde}
...
%files
%{python3_sitelib}/DoubleRatchet-%{version_main}-py%{python3_version}.egg-info/

(Generally, macros should be used for all parts that change between releases.)


I'd also do the following:
%global _description %{expand:
This python library offers an implementation of the Double Ratchet
algorithm.

A double ratchet allows message encryption providing perfect forward
secrecy. A double ratchet instance synchronizes with a second instance
using Diffie-Hellman calculations, that are provided by the DHRatchet
class.}

%description %_description
%description -n python3-doubleratchet %_description


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux