https://bugzilla.redhat.com/show_bug.cgi?id=1923678 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pemensik@redhat.c | |om) | --- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> --- Thank you for review! Sure, I forgot to add post and postun requirements. Added that, fixed %ghost files. I don't think %libexec/resolvconf is a problem. In unlikely scenario another resolvconf would arrive, I would just use Conflicts: instead. Those dependencies are small with almost no requirements. It is easier to remove the package, than to switch between multiple versions. With exception of systemd, which is impossible to uninstall. There can be only one resolvconf active anyway. I do not think it is necessary to make its directory alternative too. I think this directory works as place to put own modifications, so it should be real directory, not just symlink. I am not sure how %_libexecdir is good idea however, debian uses /lib/resolvconf. Moving it to %_usr/lib/resolvconf might work, similar to systemd unit files. But that seems as a cosmetic difference only. Changes are at the same URL as before. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
