https://bugzilla.redhat.com/show_bug.cgi?id=1924918 --- Comment #5 from frederic.pierret@xxxxxxxxxxxx --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > For discordfs: > > > GPL-3+ > The tag in Fedora is GPLv3+, see > https://fedoraproject.org/wiki/Licensing:Main#Software_License_List. Fixed thank you. > No %check? I see disorderfs has tests upstream. I've added check with respect to current upstream tests. Unfortunately, it works locally but not on COPR and probably not into Koji because tests are using fuse and it fails due to that. The current workaround is to "|| true" but I admin I would love any better suggestion if we have a way to handle fuse tests on build infra. > > Requires: bc > Why bc? The program is a C++ binary, does it call out to bc? bc is only used for tests. I've fixed dependency to BR. > > %files > Add '%license COPYING' Added. > > BuildArch: x86_64 > Oh, why? Is the program non-portable? It's a mistake. I've corrected it. > Also add 'BuildRequires: make'. Added too. If needed you can answer on the corresponding new ticket. I've answered here to make you easier to read my responses. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
