https://bugzilla.redhat.com/show_bug.cgi?id=1925223 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jamatos@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jamatos@xxxxxxxx Flags| |fedora-review+ --- Comment #2 from José Matos <jamatos@xxxxxxxx> --- The license is correct and appropriated for Fedora. The spec file is simple and correct. fedora-review complains: - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text The last one can also be ignored since the file LICENSE it is not a license. :-) Recycling from a previous review "After reviewing so many packages the other thing that shows up is that probably the %install section could get a macro on R-rpm-macros since this chunk appears so many times: mkdir -p %{buildroot}%{rlibdir} %{_bindir}/R CMD INSTALL -l %{buildroot}%{rlibdir} %{packname} test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so) rm -f %{buildroot}%{rlibdir}/R.css " In this case the chunk is similar: mkdir -p $RPM_BUILD_ROOT%{_libdir}/R/library %{_bindir}/R CMD INSTALL -l $RPM_BUILD_ROOT%{_libdir}/R/library %{packname} test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so) rm -rf $RPM_BUILD_ROOT%{_libdir}/R/library/R.css I should probably submit a patch to R-rpm-macros since this is tedious and repetitive. :-) The package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
