https://bugzilla.redhat.com/show_bug.cgi?id=1922858 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- > Source0: https://github.com/zyga/zmk/releases/download/v%{version}/%{name}-%{version}.tar.gz This can be shortened to "%{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz" Also, I see that you GPG sign your tarballs, you can also have their GPG signatures verified: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_verifying_signatures > . > Highlights include: > . What are these "." for? > rm -rf $RPM_BUILD_ROOT This should not be present, please remove it. > %{_mandir}/man5/zmk.*.5.gz > %{_mandir}/man5/z.mk.5.gz Man pages can be compressed in gz, xz, zstd, or nothing at all, so just use "5*" here Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages > * Wed Feb 03 2021 Zygmunt Krynicki - 0.5-1 > - New upstream release > - Simplify prep and build steps Changelog is not exactly in the correct format (missing email address): https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
