https://bugzilla.redhat.com/show_bug.cgi?id=1881482 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(andrey.matyukov@i | |ntel.com) --- Comment #21 from code@xxxxxxxxxxxxxxxxxx --- Thanks for your comments and your revisions. And thanks for taking the time to get this package into the distribution! I found only a few small things that need to be adjusted before I can approve the package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Rather than patching from -O3 to -O2, -set(CMAKE_C_FLAGS_RELEASE "-O3 -DNDEBUG" CACHE STRING "" FORCE) +set(CMAKE_C_FLAGS_RELEASE "-O2 -DNDEBUG" CACHE STRING "" FORCE) just patch out the explicit optimization flag and let the CFLAGS from the system (which will contain -O2) prevail: -set(CMAKE_C_FLAGS_RELEASE "-O3 -DNDEBUG" CACHE STRING "" FORCE) +set(CMAKE_C_FLAGS_RELEASE "-DNDEBUG" CACHE STRING "" FORCE) The point is not to *override* build flags without justification. - The patch that drops the explicit -O3 also adds #pragma GCC optimize ("O0") before several CPU feature detection routines. This part of the patch has a different purpose; please at least add a comment in the spec file explaining why it is needed. It may be cleaner to split it into a separate patch, but that is up to you. - The file sources/ippcp/asm_intel64/gcm_keys_avx512.inc has a 3-clause BSD license in its header. Please follow https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios. The overall package license should be “ASL 2.0 and BSD”, and there must be a comment explaining the licensing breakdown. For example, above the License field: # The entire source code is ASL 2.0 except # sources/ippcp/asm_intel64/gcm_keys_avx512.inc, which is BSD License: ASL 2.0 and BSD - The expanded README URL in the description is too long (80 character limit); unfortunately, you will have to put a line break in it somewhere. See the rpmlint messages and https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "BSD 3-clause "New" or "Revised" License". 38 files have unknown license. Detailed output of licensecheck in /home/reviewer/1881482-intel-ipp-crypto-mb/licensecheck.txt One file is licensed BSD. See Issues, above, for what to do. [x]: License file installed when any subpackage combination is installed. [!]: %build honors applicable compiler flags or justifies otherwise. Very close; see Issues, above [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. Package does require ExcludeArch, in the form of ExclusiveArch. A proper justification comment is present, which must be replaced by links to Bugzilla bugs for all unsupported architectures after the package is approved (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures). [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. See Issues, above [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. No general-purpose tests provided by upstream [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: intel-ipp-crypto-mb-1.0.1-1.fc34.x86_64.rpm intel-ipp-crypto-mb-devel-1.0.1-1.fc34.x86_64.rpm intel-ipp-crypto-mb-1.0.1-1.fc34.src.rpm intel-ipp-crypto-mb.x86_64: E: description-line-too-long C https://github.com/intel/ipp-crypto/blob/ippcp_2020u3/sources/ippcp/crypto_mb/Readme.md intel-ipp-crypto-mb-devel.x86_64: W: no-documentation intel-ipp-crypto-mb.src: E: description-line-too-long C https://github.com/intel/ipp-crypto/blob/ippcp_2020u3/sources/ippcp/crypto_mb/Readme.md 3 packages and 0 specfiles checked; 2 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- intel-ipp-crypto-mb-devel.x86_64: W: no-documentation intel-ipp-crypto-mb.x86_64: E: description-line-too-long C https://github.com/intel/ipp-crypto/blob/ippcp_2020u3/sources/ippcp/crypto_mb/Readme.md 2 packages and 0 specfiles checked; 1 errors, 1 warnings. Source checksums ---------------- https://github.com/intel/ipp-crypto/archive/ippcp_2020u3.tar.gz#/intel-ipp-crypto-mb-ippcp_2020u3.tar.gz : CHECKSUM(SHA256) this package : 0dfe8efdd85c75038027484d9343185fbd92b607a8558d65bed1caf8f5b9011c CHECKSUM(SHA256) upstream package : 0dfe8efdd85c75038027484d9343185fbd92b607a8558d65bed1caf8f5b9011c Requires -------- intel-ipp-crypto-mb (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) rtld(GNU_HASH) intel-ipp-crypto-mb-devel (rpmlib, GLIBC filtered): intel-ipp-crypto-mb(x86-64) libcrypto_mb.so.1()(64bit) Provides -------- intel-ipp-crypto-mb: intel-ipp-crypto-mb intel-ipp-crypto-mb(x86-64) libcrypto_mb.so.1()(64bit) intel-ipp-crypto-mb-devel: intel-ipp-crypto-mb-devel intel-ipp-crypto-mb-devel(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1881482 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Python, Java, Haskell, PHP, Ocaml, SugarActivity, fonts, R, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
