[Bug 1922147] Review Request: libdatovka - Client library for accessing SOAP services of ISDS (Czech Data Boxes)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1922147



--- Comment #4 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> ---
(In reply to Jan Žerdík from comment #3)

Thanks for the review.

> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> 
> Issues:
> =======
> - package does not own directory /usr/include/libdatovka

It should be fixed now.

> - "client" folder to "-doc" package?

It makes sense. Maybe -examples could be better? But I went with the -doc in
case there will be some more docs (e.g. API docs) in the future.

> - czech description and summary?

Nice to have, but there are no Czech docs in the Datovka itself, so I am not
adding it.

> Generic:
> [!]: Package should not use obsolete m4 macros
>      Note: Some obsoleted macros found, see the attachment.
>      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

Upstream was notified about the problem.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux