Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: smstools - Tools for send and receive short messages through GSM modems or mobile phones https://bugzilla.redhat.com/show_bug.cgi?id=374771 ------- Additional Comments From mmahut@xxxxxxxxxx 2007-11-12 14:17 EST ------- (In reply to comment #6) > Sooo, Marek: > > In my opinion you shouldn't change modes in threee different places; (ugly > chmods in %prep, install -m %install and %attr in %files). Done, let me know if it's ok. > And RPMlint: > > smstools.i386: W: file-not-utf8 > /usr/share/doc/smstools-3.0.6/manual/softwarecomp.html > ... > > Alreay discussed that, not a problem. > > smstools.i386: W: file-not-utf8 > /usr/share/doc/smstools-3.0.6/examples/send_sms_unicode.sms > > UNICODE example, whouldn't make sense if was utf8 > > smstools.i386: E: non-standard-dir-perm /var/spool/sms/failed 0750 > smstools.i386: E: non-standard-dir-perm /var/spool/sms/checked 0750 > smstools.i386: E: non-standard-dir-perm /var/spool/sms/outgoing 0750 > smstools.i386: E: non-readable /etc/smsd.conf 0600 > smstools.i386: E: non-standard-dir-perm /var/spool/sms/sent 0750 > smstools.i386: E: non-standard-dir-perm /var/spool/sms/incoming 0750 > smstools.i386: E: non-standard-dir-perm /var/spool/sms 0750 > > I think this is all intended Indeed. > smstools.i386: E: incoherent-subsys /etc/rc.d/init.d/smsd smstools > smstools.i386: E: incoherent-subsys /etc/rc.d/init.d/smsd smstools > smstools.i386: E: incoherent-subsys /etc/rc.d/init.d/smsd smstools > > Using /var/lock/subsys/smsd for a subsys lock instead of > /var/lock/subsys/smstools would make more sense in my opinion. Done. > smstools.i386: W: incoherent-init-script-name smsd > > Perfectly ok > > smstools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 66, tab: line 1) > > Run expand on the spec. Done. Updated spec file: http://mmahut.fedorapeople.org/reviews/smstools/3.0.6/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review