[Bug 1919639] Review Request: DOSBox-X - DOS/x86 emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1919639



--- Comment #7 from Vladislav Kazakov <vpackager@xxxxxxxxx> ---
> Also, I used [AT] instead of @ in the email to reduce spam, I thought that was acceptable.

Yes, this is acceptable. I just thought it was a copying error.

>>The moment I change that, it seems that the configure flags specified are thrown out of the window and the compile just fails as it ends up looking for SDL1 libraries instead of SDL2.
> If someone can tell me how to use the %configure macro while keeping the flags, I would appreciate it.

You can keep flags just like that:
"""
 %configure --enable-core-inline --enable-debug=heavy --enable-sdl2
"""
But it falls anyway whille compiling sdlmain.cpp, because the %configure adds
-Werror=format-security to g++:
"""
sdl_ttf.c:334:18: error: format not a string literal and no format arguments
[-Werror=format-security]
334 |  TTF_SetError(msg);
        |                                  ^
"""
It would be nice to fix this in upstream. Or you can just remove
-Werror=format-security.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux