https://bugzilla.redhat.com/show_bug.cgi?id=1919037 Chris Rummel <crummel@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Chris Rummel <crummel@xxxxxxxxxxxxx> --- Allowed package: good. Naming: good. Version and release: good. Licensing: good. Library/application: good. Packages MUST specify their dependencies: good. Desktop applications MUST NOT depend on other desktop applications: N/A. Spec file - naming: good. - legibility: good. - encoding: good. - outside repo: N/A. Source file verification: N/A. Architecture support: good. Filesystem layout: good. RPMLint: clean. Tags and sections: good. Dependencies: good. Build-time dependencies: good. Summary and description: good. Documentation: good. Changelog: good. Man pages: good. Compiler: good. Compiler flags: good. Debuginfo: good. Devel packages: N/A. Requiring base packages: good. Shared libraries: good. Static libraries: N/A. Bundling and duplication of libraries: good. Rpath: good. Config files: good. Initscripts: good. Systemd units: N/A. Desktop files: N/A. AppData files: N/A. Macros: good. Scripting: N/A. Locale: good. Log files: N/A. Ownership: good. Users and groups: N/A. Web applications: N/A. Patches: - Patch1: source-build-runtime-fixup-linker-order.patch need an upstream bug is missing an upstream bug or comment. Epoch: N/A. Symlinks: good. Test suite: N/A. binfmt, sysctl, tmpfiles: N/A. Renaming/replacing/deprecating packages: N/A. IPv6: good. Cron files: N/A. Security updates: N/A. Build-time network access: N/A. Bootstrapping: good. Shebangs: N/A. BuildRoot policy: N/A. EPEL: N/A. This passes but the missing comment or upstream bug for the patch should be fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
