https://bugzilla.redhat.com/show_bug.cgi?id=1909767 Fabiano Fidêncio <fidencio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fidencio@xxxxxxxxxx --- Comment #3 from Fabiano Fidêncio <fidencio@xxxxxxxxxx> --- Christophe, Firstly, let me thank you for the review. I'll try to address the top-level comments. (In reply to Christophe de Dinechin from comment #1) > c3d top-level comments: > > - A few suggested changes, search for [S] below. Nothing really blocking Yay! :-) > - Why do we mark this as conflicting with kata-ksm-throttler? > I need to check if kata-ksm-throttler is still supposed to work with 2.0 > but I see no reason why not. My approach was to mark everything that's related to 1.x as conflicting. If kata-ksm-throttler works fine for 2.x, we'd better deal with this upstream in the following way: * Check what's needed to make it work, in case it doesn't work automagically; * Move ksm-throttler under 2.x repo, probably under the `tools/` folder; * Then we get it for free as part of the next rebase; Does this sound reasonable? > - Consider Obsoletes instead of Conflicts for packages such as kata-runtime > or > kata-shim. I will trust your choice, however, if you tell me that > Conflicts: > is better in that specific case. In order to simplify things for us and for the consumers, I'd prefer using either "Obsoletes" or "Conflicts". The reason I decided to go with "Conflicts" was nothing but ideological, but I'm more than fine to change it according to your preference. Again, I'd prefer we decide for one and go for one of those. What do you think? > - Have you tried installing back and forth between 1.x and 2.0 packages? I, personally, haven't. May I ask what's your concern? > - When this is accepted, can we add a Conflicts: in the other packages? We surely can, no problem. Out of curiosity, what do you have in mind? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
