https://bugzilla.redhat.com/show_bug.cgi?id=1919347 --- Comment #5 from d.hatayama@xxxxxxxxxxx --- Vladislav, (In reply to d.hatayama from comment #4) > Thanks for your comments, Vladislav. > > (In reply to Vladislav Kazakov from comment #2) > > Hello. Thanks for bringing your package to Fedora! > > I will make a couple of comments on your spec while you wait for a actual > > reviewer. > > > > It's better to start versioning your libraries. As the upstream maintainer > > you can do that. Please, see: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > #_downstream_so_name_versioning > > I'll do this in the upstream. But I have one question. Is it acceptable in > this package review to compose the source rpm with the tar file that has not > been released yet? The question is because I want to avoid repeating > releasing > new versions during this review. Of course, I'll use a released version > after I could complete this package review. I overlooked the following sentence saying the version is not needed for plugins. In cases where upstream ships unversioned .so library (so this is not needed for plugins, drivers, etc.), the packager MUST try to convince upstream to start versioning it. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ That is, gcore.so provided by crash-gcore-command is a plugin, so I think there is no need to do this here. This is same for trace.so provided by crash-trace-command in BZ#1919349. On the other hand, rpmlint shows warning if solib has no soname, so I'll add soname in the upstream. Thanks. HATAYAMA, Daisuke -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
