Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 ------- Additional Comments From konradr@xxxxxxxxxx 2007-11-12 11:45 EST ------- A) You need to have Requires for the binaries you are using in the scriptlets. So this is required: Requires(post): /sbin/ldconfig Requires(post): /sbin/chkconfig B) %post, %preun and %postun section: You should reorganize this and re-use your macros: /sbin/ldconfig if [ $1 = 1 ]; then /sbin/chkconfig --add %{name} if [ $? == 0 ]; then /sbin/chkconfig --level 35 %{name} on fi fi (take a look at http://ibmasm.cvs.sourceforge.net/*checkout*/ibmasm/ibmasm/ibmasm.spec?revision=1.10 for examples what else to do in scriptlets) C). Attributes: <code> iles devel %defattr(755, root, root) %{_libdir}/libtspi.so %attr(644, root, root) %{_libdir}/libtddl.a %attr(644, root, root) %{_includedir}/tss/*.h %attr(644, root, root) %{_includedir}/trousers/*.h %attr(644, root, root) %{_mandir}/man3/Tspi_* </code> You use the 644 attr most of the time, why not make the defattr 644, and label 755 the libtspi (should it even be 755?) D). rpmlint. konrad@dl380 ~]$ rpmlint -v trousers-0.3.1-1cvs.src.rpm trousers.src: I: checking trousers.src:37: W: setup-not-quiet trousers.src:95: W: macro-in-%changelog files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review