https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #49 from Warren Togami <wtogami@xxxxxxxxx> --- > - permissions of /etc/bitcoin folder (0750) too strict - ordinary users cannot view conf You mean bitcoin.conf? You absolutely do not want other users to be able to read that. It can contains secrets. Overall I have concerns that this package shoehorns non-default config and datadir. This is not the "normal" way of using bitcoind. This package entering the repository could be a surprise to some with several external repo packages that people have installed in the past years. I wrote related concerns of packaging conflicts at https://bugzilla.redhat.com/show_bug.cgi?id=1020292#c45 > # FIXME This is less than ideal, but until dwalsh gives me a better way... Mitigating factor is if all the non-upstream-default stuff is in an optional subpackage. In your case -server does seem to self-contain the .service, selinux, non-default config and non-default datadir. If people want to use it in the upstream way they could install only the main package. (I have not fully reviewed if these things are fully contained in the -server subpackage.) > * Wed Jul 22 2020 Simone Caronni <negativo17@xxxxxxxxx> - 0.20.0-7 > - Use libdb 5.x instead of deprecated 4.x. Fixes build on RHEL/CentOS 8. Sorry please do not do this. Upstream strongly recommends against using DB5 for a reason. db4 is the official upstream wallet.dat format. They plan to migrate away from db4 to sqlite in the next year. Building against db5 is in the build system as only a convenience but it is strongly discouraged all these years because db5 wallet.dat is not supported by the upstream distribution, and it could leave users stuck without a supported migration path. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
