Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: docbook-simple https://bugzilla.redhat.com/show_bug.cgi?id=225701 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-12 07:25 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But NOT for RPM. docbook-simple.noarch: W: dangerous-command-in-%post chmod docbook-simple.noarch: W: dangerous-command-in-%postun rm => these messages can be ignored for this package. + source files match upstream. f31c63f121033a72869286d4a0416421 docbook-simple-1.1.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + xml and sgml catalogs are called in post and postun sections. + package docbook-simple-1.1-3.fc8 -> Provides: config(docbook-simple) = 1.1-3.fc8 Requires: config(docbook-simple) = 1.1-3.fc8 docbook-dtds sgml-common + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review