https://bugzilla.redhat.com/show_bug.cgi?id=1912855 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(alebastr89@gmail. | |com) | --- Comment #2 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- (In reply to code from comment #1) Thanks for the review! > - Need to document breakdown of multiple licenses in spec file. > A comment above the License field like the following would suffice. Thanks for catching this, fixed in new revision. I thought I've already done that... > - A new change in Fedora 34 is that make is not included in the buildroot. > While gcc currently pulls in make as a transitive dependency, this could > change. You must add a BR on make. (I think this is still not in the > Guidelines.) Or, do “%meson -GNinja” and add a BR on ninja-build instead. 1. meson already uses ninja and doesn't support other generators on Linux. I think you're confusing it with cmake. 2. As per change discussion, BR: make is not needed for meson or cmake projects unless make is used in the spec file explicitly. It's the job of cmake and meson packages to depend on the appropriate generator. The common consent was that for %meson/%meson_build/... and %cmake/%cmake_build/... families of macros the packager is not aware of the default generator and should not care about it. > - Since tllist is a header-only library, you must BR tllist-static, even > though you already BR pkgconfig(tllist). A little silly, I think, but > mandatory. I feel that it defeats the whole purpose of pkgconfig(...) macros, but applied anyways. Spec URL: https://copr-be.cloud.fedoraproject.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01896898-fcft/fcft.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01896898-fcft/fcft-2.3.2-0.1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
