Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xqilla101 - XQilla is an XQuery and XPath 2.0 library, built on top of Xerces-C https://bugzilla.redhat.com/show_bug.cgi?id=376541 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-12 06:24 EST ------- For 1.0.1-3: * SourceURL - Please specify full URLs for Source0/1. * Redundant (Build)Requires - I guess "xerces-c-devel >= 2.7.0" BuildRequires should pull "xerces-c >= 2.7.0". * Duplicate entry - The entry "License" or "URL" is needed only once for description unless they differ between subpackages. * EVR specific dependency between subpackages - Usually dependency between subpackages must be EVR (Epoch-Version-Release) (i.e. not only EV) specific. i.e. Usually -devel package should have "Requires: %{name} = %{version}-%{release}". * Dependency for xerces-c - Is xqilla101 has to be rebuilt (or will you want to rebuild) against new xerces-c if xerces-c is upgraded to 2.7.1, for example? (i.e. ABI not changed but updated with some reason)? If so, it may be better that xquilla101 has version specific dependency against xerces-c. - Also xqilla101-devel Requires (not BuildRequires) xerces-c-devel. * Timestamps - When you use "cp" or "install" commands, please add "-p" option to keep timestamps. - Also, for this package the following method will keep timestamps on installed header files (this method usually works for packages using "install-sh" for "make install"). --------------------------------------------------------------------- %install rm -rf %{buildroot} export CPPROG="cp -p" make install DESTDIR=%{buildroot} --------------------------------------------------------------------- * One line /sbin/ldconfig scriptlet call - To remove unneeded sh call, please replace this by --------------------------------------------------------------------- %post -p /sbin/ldconfig --------------------------------------------------------------------- for example. * devel-file-in-non-devel-package /usr/lib/libxqilla.so rpmlint - %_libdir/libxqilla.so must be moved to -devel package * Namespace conflict - Well, the reason this rpm is named xqilla101, not the direct xqilla101 is to make it sure that someone can package the latest xqilla and can import to Fedora. For that case, the libraries' name and the header directory must be renamed. - %_libdir/libxqilla.so should be renamed to %_libdir/libxqilla101.so, for example (also soname should be changed). ----------------------------------------------------------------------- 1368 g++ -shared -nostdlib .... -Wl,-soname -Wl,libxqilla.so.1 -o .libs/libxqilla.so.1.0.0 ----------------------------------------------------------------------- - %_includir/xqilla should be moved to %_includedir/xqilla101 - %_bindir/xqilla should also be renamed. * defattr - Now we recommend: %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review