https://bugzilla.redhat.com/show_bug.cgi?id=1919295 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #1 from code@xxxxxxxxxxxxxxxxxx --- Comments on rpmlint messages: npm-name-cli.noarch: E: useless-provides bundled(nodejs-ansi-styles) [… many similar messages …] I do not know why rpmlint thinks this is useless, but these are the required virtual Provides for the bundled node dependencies. All node-based RPMs under the new guidelines will have them. npm-name-cli.noarch: W: only-non-binary-in-usr-lib All node-based RPMs will have this as well, based on the location of /usr/lib/node_modules/ (%node_sitelib). npm-name-cli.noarch: W: hidden-file-or-dir /usr/lib/node_modules/npm-name-cli/node_modules/.bin [… many similar messages …] Dotfiles under node_modules are normal. npm-name-cli.noarch: E: script-without-shebang /usr/lib/node_modules/npm-name-cli/node_modules_prod/@types/normalize-package-data/package.json [… many similar messages …] My view is that blindly attempting to correct the many extra or missing executable bits in bundled node module dependencies is a fool’s errand, more likely to accidentally break something than accomplish anything useful. (I would be willing to chmod a-x all .json files if a reviewer felt strongly about it.) npm-name-cli.noarch: E: zero-length /usr/lib/node_modules/npm-name-cli/node_modules_prod/package-json/node_modules/@sindresorhus/is/dist/example.d.ts Again, there is no reason to go mucking around inside the bundled dependencies. npm-name-cli.src: W: no-%build-section Normal for a node-based RPM; there is nothing to do. npm-name-cli.src: W: invalid-url Source1: npm-name-cli-3.0.0-nm-prod.tgz This is the usual bundled dependencies tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
