https://bugzilla.redhat.com/show_bug.cgi?id=476234 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #29 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Use %global not %define %global srcname mindi-busybox - Release should start at 1. Also please explain the extra release parameters: Release: 0.20201126002730.s3777M%{dist} - This ned to be justified usually: # Cf: https://bugzilla.redhat.com/show_bug.cgi?id=588550 ExcludeArch: ppc We don't support ppc anymore, only ppc64le. - Please justify this or fix the package to make debuginfo work: # Avoids to generate debug packages %global debug_package %{nil} The issue seems to be that busybox is stripped by the build process: strip -s --remove-section=.note --remove-section=.comment \ busybox_unstripped -o busybox - Please provide the patch unzipped: Patch0: 02-stime.fedora-33.gz - Please add a comment explaining what the patch does or why it is needed Not needed: rm -rf $RPM_BUILD_ROOT %clean rm -rf $RPM_BUILD_ROOT %defattr(-,root,root) - The license file must be included with %license in %files: %doc ChangeLog AUTHORS README TODO NEWS %license LICENSE - Add a BR for make - Use %make_build instead of make X - Use %set_build_flags before make to use Fedora build flags -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
