https://bugzilla.redhat.com/show_bug.cgi?id=1903509 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) | --- Comment #4 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- (In reply to Michel Alexandre Salim from comment #1) > Taking this review > > Some initial notes: > - use %py_provides instead of %python_provide if you want to target Fedora > 32 or below. For F33 or above you don't need this at all: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_the_py_provides_macro > - you can use %{py3_dist ...} instead of python3dist(...) - > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_requires_and_buildrequires_with_standardized_names > this is optional though Thanks, for the feedback. Updated %changelog * Wed Jan 20 2020 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> - 0.4.4-2 - Update to new macros (#1903509) Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-wled.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-wled-0.4.4-2.fc33.src.rpm Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
