https://bugzilla.redhat.com/show_bug.cgi?id=1917998 --- Comment #2 from Frank Ch. Eigler <fche@xxxxxxxxxx> --- Generally looks fine & simple. A few nits: - Source: github url should be corrected - Consider noting the oc dependency (origin-clients or perhaps kubernetes-client) - Consider noting the java related soft dependencies - @JAVA_HOME@ needs to be expanded properly within oc-inject, maybe to an os.environ[] expression? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
